prevent wrong Evolve behavior, pls do n't change meaning of mnemonic parameters #2213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hanges before commit to master, Evolve*KEPT*PokemonsAtStorageUsagePercentage have only one certain meaning. If you want change logic then pls rename parameter to EvolvePokemonsAtStorageUsagePercentage without KEPT. Without this check people who wants to evolve pokemon with above IV or just with enough candy, but with options KeepPokemonsThatCanEvolve = false (case with default config for new users) will never have it, and even their pokemon mightl be transfered instead of evolving...
|
Fantastic work. Working as it did on ver 5.0. |
schnapster
pushed a commit
to schnapster/NecroBot
that referenced
this pull request
Dec 8, 2016
prevent wrong Evolve behavior, pls do n't change meaning of mnemonic parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pls, dont break the logic of evolve behavior, analyze and test your changes before commit to master, Evolve_KEPT_PokemonsAtStorageUsagePercentage have only one certain meaning. If you want change logic then pls rename parameter to EvolvePokemonsAtStorageUsagePercentage without KEPT.
Without this check people who wants to evolve pokemon with above IV or just with enough candy, but with options KeepPokemonsThatCanEvolve = false (case with default config for new users) will never have it, and even their pokemon might be transfered instead of evolving... (sry for my bad english)